Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env data in output #665

Merged
merged 22 commits into from
May 3, 2024
Merged

Env data in output #665

merged 22 commits into from
May 3, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Injects env data into output manifest.

Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great to me. I've checked out the branch and verified locally that:

  • the packages in npm list are added to the manifest as a list in execution/environment
  • packages installed from github include all the relevant information for recreating the precise install (link with commit hash)
  • os and os-version are formatted as expected
  • execution command is correctly reported in execution/command

Good to move to QA review

@MariamKhalatova MariamKhalatova merged commit cd9ccc2 into main May 3, 2024
2 checks passed
@MariamKhalatova MariamKhalatova deleted the env-data-in-output branch May 3, 2024 16:17
This was referenced May 17, 2024
@github-actions github-actions bot mentioned this pull request Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

👍🏼 Update IF to report runtime information to outputs
3 participants