-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV Lookup builtin plugin #754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some test manifests and tidied up the readme, but otherwise this seems good. I have played around with it quite a bit and checked that it does what we expected. I haven't found any unexpected behaviour. Happy to pass to qa.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@narekhovhannisyan When the value of output
doesn't match with existing key, in the result output section a new param with the value of output
value appears .
Expected result: Throw appropriate error
@narekhovhannisyan When a value of output field is a two dimensional array and arrays contain only one field name, the output is broken. |
@narekhovhannisyan When plugin output is |
@narekhovhannisyan please also check, all exported values are string. |
@MariamKhalatova I've pushed fixes, please check |
Types of changes
A description of the changes proposed in the Pull Request