Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Lookup builtin plugin #754

Merged
merged 22 commits into from
Jun 5, 2024
Merged

CSV Lookup builtin plugin #754

merged 22 commits into from
Jun 5, 2024

Conversation

narekhovhannisyan
Copy link
Member

@narekhovhannisyan narekhovhannisyan commented May 31, 2024

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • This pull request adds CSV Lookup plugin to if framework's builtins.
  • Covers the introduced changes with documentation and unit tests.
  • Adds appropriate manifests samples.

@narekhovhannisyan narekhovhannisyan marked this pull request as draft May 31, 2024 16:53
@narekhovhannisyan narekhovhannisyan self-assigned this May 31, 2024
@narekhovhannisyan narekhovhannisyan linked an issue May 31, 2024 that may be closed by this pull request
10 tasks
@narekhovhannisyan narekhovhannisyan marked this pull request as ready for review June 2, 2024 06:43
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some test manifests and tidied up the readme, but otherwise this seems good. I have played around with it quite a bit and checked that it does what we expected. I haven't found any unexpected behaviour. Happy to pass to qa.

@narekhovhannisyan narekhovhannisyan changed the title Csv lookup CSV Lookup builtin plugin Jun 3, 2024
Copy link
Contributor

@MariamKhalatova MariamKhalatova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narekhovhannisyan When the value of output doesn't match with existing key, in the result output section a new param with the value of output value appears .
Expected result: Throw appropriate error
Screenshot 2024-06-04 at 1 54 31 AM

@MariamKhalatova
Copy link
Contributor

@narekhovhannisyan When a value of output field is a two dimensional array and arrays contain only one field name, the output is broken.
Screenshot 2024-06-04 at 12 04 26 PM

@MariamKhalatova
Copy link
Contributor

MariamKhalatova commented Jun 4, 2024

@narekhovhannisyan When plugin output is "*", outputs contain duplicates from query.

Screenshot 2024-06-04 at 9 57 31 PM

@MariamKhalatova
Copy link
Contributor

@narekhovhannisyan please also check, all exported values are string.

@narekhovhannisyan
Copy link
Member Author

@MariamKhalatova I've pushed fixes, please check

@zanete zanete removed the feature label Jun 5, 2024
@MariamKhalatova MariamKhalatova merged commit 45e48ba into main Jun 5, 2024
1 check passed
@MariamKhalatova MariamKhalatova deleted the csv-lookup branch June 5, 2024 22:16
This was referenced Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Build a generic csv-lookup plugin
4 participants