Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if-diff: Ignore certain fields from manifest #796

Merged
merged 1 commit into from
Jun 11, 2024
Merged

if-diff: Ignore certain fields from manifest #796

merged 1 commit into from
Jun 11, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Ignores name, description, tags and initialize outputs fields.

@narekhovhannisyan narekhovhannisyan self-assigned this Jun 10, 2024
@narekhovhannisyan narekhovhannisyan linked an issue Jun 10, 2024 that may be closed by this pull request
Update if-diff to ignore outputs name description and tags #792
Closed
2 tasks
jmcook1186
jmcook1186 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jmcook1186 jmcook1186 merged commit ac3be1f into main Jun 11, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the if-diff-ignore-fields branch June 11, 2024 14:08
This was referenced Jun 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@manushak manushak manushak approved these changes

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update if-diff to ignore outputs name description and tags
3 participants
@narekhovhannisyan @manushak @jmcook1186