Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix If-env node_modules issue #862

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Fix If-env node_modules issue #862

merged 2 commits into from
Jun 26, 2024

Conversation

manushak
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

@manushak manushak self-assigned this Jun 26, 2024
@manushak manushak linked an issue Jun 26, 2024 that may be closed by this pull request
[IF-Env] Generates incorrect package.json when there is also node-modules inside the folder #860
Closed
MariamKhalatova
MariamKhalatova approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@MariamKhalatova MariamKhalatova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified!

@MariamKhalatova MariamKhalatova merged commit 0c12408 into main Jun 26, 2024
2 checks passed
@MariamKhalatova MariamKhalatova deleted the if-env-modules branch June 26, 2024 16:48
This was referenced Jun 28, 2024
Merged
Merged
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamKhalatova MariamKhalatova MariamKhalatova approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

Assignees

@manushak manushak

Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[IF-Env] Generates incorrect package.json when there is also node-modules inside the folder
3 participants
@manushak @narekhovhannisyan @MariamKhalatova