Emit warning #942
Merged
Emit warning #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narekhovhannisyan
requested review from
manushak,
jmcook1186 and
MariamKhalatova
1 task
jmcook1186
approved these changes
Aug 7, 2024
manushak
reviewed
Aug 8, 2024
manushak
reviewed
Aug 8, 2024
src/if-run/lib/compute.ts
Outdated
| @@ -77,6 +78,10 @@ const computeNode = async (node: Node, params: ComputeParams): Promise<any> => { | |||
| inputStorage = mergeDefaults(inputStorage, defaults); | |||
| const pipelineCopy = structuredClone(pipeline) || {}; | |||
|
|
|||
| if (Object.keys(pipelineCopy).length === 0) { | |||
There was a problem hiding this comment.
the Object.keys(pipelineCopy).length has [ '0' ] if there isn't compute, observe or regroup in the manifest. You can test manifests/examples/builtins/sum/success.yml
by commenting compute and fixing the tabulation
manushak
requested changes
Aug 8, 2024
Co-authored-by: Manushak Keramyan <manushak.keramyan@gmail.com> Signed-off-by: Narek Hovhannisyan <narekgilmour@gmail.com>
|
@manushak I'm unable to reproduce that case, can you please provide more background on it? |
manushak
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
A description of the changes proposed in the Pull Request