fix: return any possible error reasons from greptimedb:is_alive(Client, true)
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt, true)`
grpcbox may return `{http_error, _, _}` which doesn't match `{error, Reason}` pattern.
killme2008
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
A tiny improvement for
is_alive(Client, true).I think if a caller requested
ReturnReason, it's better to ensure the Reason is always returned, even if the error itself doesn't match{error, Reason}pattern.The later may happen in a real world scenario, since grpcbox also returns
{http_error, _, _}which doesn't match{error, Reason}: https://github.com/tsloughter/grpcbox/blob/v0.17.1/src/grpcbox_client.erl#L104