-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supports gRPC insertion hints, close #42 #43
Conversation
WalkthroughThis pull request introduces several updates across multiple files. It upgrades the GreptimeDB version in the GitHub Actions workflow, adds a new Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant greptimedb_worker
participant GreptimeDB
Client->>greptimedb_worker: Initiate request with grpc_hints
greptimedb_worker->>GreptimeDB: Send request with hints
GreptimeDB-->>greptimedb_worker: Acknowledge request
greptimedb_worker-->>Client: Return response
Poem
Tip Announcements
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional context usedMarkdownlint
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (3 hunks)
Additional context used
Markdownlint
README.md
216-216: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
217-217: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
218-218: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
219-219: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
220-220: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
Additional comments not posted (2)
README.md (2)
25-25
: LGTM!The code change is approved. Adding the
grpc_hints
option with an empty map as the default value is a valid way to introduce support for gRPC insertion hints.
133-138
: Verify the relevance of this change.The added section describes how to check if the client is alive using the
greptimedb:is_alive/1
function. While the change itself is valid, it's unclear how it relates to the PR objective of introducing support for gRPC insertion hints.Please clarify the purpose of this change in the context of this PR. If it's unrelated, consider moving it to a separate PR.
Supports gRPC insertion hints while creating tables automatically, adds a new option
gprc_hints
.For example, enable
append_mdoe
:Summary by CodeRabbit
New Features
grpc_hints
for enhanced flexibility when connecting to GreptimeDB, allowing users to provide insertion hints for gRPC operations.Improvements
ecpool
library dependency to version 0.5.9 for improved functionality.Bug Fixes