-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect peer_addr in cluster_info meta table #4186
Comments
I think |
But in another meaning, they are serving the same purpose - gRPC requests, wherever they come from users or internal requests. |
The |
One scenario I realized using port here may make sense is when multiple instances deployed on a single node, we use port as some sort of process id. I'm ok to keep it until we find better alternatives. We still need to explain the meaning of the ports when it's listed on cluster topology view. |
We can add a |
* fix: frontend registration address is wrong, #4186 * fix: license header * chore: adds hostname to frontend grpc * fix: forgot run make config-docs * chore: warn when using bind_addr * fix: flow node heartbeat carrying address
What type of bug is this?
Incorrect result
What subsystems are affected?
Distributed Cluster
Minimal reproduce step
select * from information_schema.cluster_info
What did you expect to see?
This
peer_addr
field has different implementation for different peer types.--rpc-hostname
parameter, which uses hostname of the node. This is preferred for displaying host address.Also we should not show grpc port here because on these three node types, grpc serves different purpose and its meaningless to list them together.
What did you see instead?
What operating system did you use?
any
What version of GreptimeDB did you use?
HEAD
Relevant log output and stack trace
No response
The text was updated successfully, but these errors were encountered: