Make pg_catalog schema visible only when client connect from Postgres protocol #4543
Labels
C-enhancement
Category Enhancements
Comments
|
assign this to me. |
J0HN50N133
added a commit
to J0HN50N133/greptimedb
that referenced
this issue
Aug 17, 2024
3 tasks
J0HN50N133
added a commit
to J0HN50N133/greptimedb
that referenced
this issue
Aug 25, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 9, 2024
* fix: table resolving logic related to pg_catalog refer to #3560 (comment) and #4543 * refactor: remove CatalogProtocol type * fix: sqlness * fix: forbid create database pg_catalog with mysql client * refactor: use QueryContext as arguments rather than Channel * refactor: pass None as default behaviour in information_schema * test: fix test
CookiePieWw
pushed a commit
to CookiePieWw/greptimedb
that referenced
this issue
Sep 17, 2024
* fix: table resolving logic related to pg_catalog refer to GreptimeTeam#3560 (comment) and GreptimeTeam#4543 * refactor: remove CatalogProtocol type * fix: sqlness * fix: forbid create database pg_catalog with mysql client * refactor: use QueryContext as arguments rather than Channel * refactor: pass None as default behaviour in information_schema * test: fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What type of enhancement is this?
API improvement
What does the enhancement do?
This was a comment from the initial PR of pg_catalog feature #4332 . This
pg_catalogis designed to work with postgresql client tools like psql to get meta information of the database. It should only be visible when client connects from postgresql protocol. We should not see it from our mysql clients, and http dashbaord.Implementation challenges
Check the
QueryContextto see current whether current client is from postgresql port or not.The text was updated successfully, but these errors were encountered: