build: specify clippy denies in cargo config #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #1351 +/- ##
===========================================
- Coverage 85.49% 85.08% -0.41%
===========================================
Files 514 514
Lines 77471 77471
===========================================
- Hits 66230 65914 -316
- Misses 11241 11557 +316 |
evenyag
reviewed
Apr 10, 2023
evenyag
approved these changes
Apr 10, 2023
|
Maybe add a line about "-Wclippy::implicit_clone"? clippy::implicit_clone deny usage of |
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
|
Added in 4b20b22, thanks for suggestion |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* build: specify clippy denies in cargo config Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * deny implicit clone Signed-off-by: Ruihang Xia <waynestxia@gmail.com> --------- Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Specify clippy denies (
-D clippy::print_stdout -D clippy::print_stderr) in cargo config. Reduce duplicate settings.Checklist
Refer to a related PR or issue link (optional)