Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for show full tables #2410

Merged
merged 11 commits into from
Sep 22, 2023
Merged

feat: support for show full tables #2410

merged 11 commits into from
Sep 22, 2023

Conversation

Lilit0x
Copy link
Contributor

@Lilit0x Lilit0x commented Sep 15, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Added support for SHOW FULL TABLES .

Please explain IN DETAIL what the changes are in this PR and why they are needed:
The changes are to support listing all tables and table types in the default schema in greptimedb. The implementation is similar to MySQL.

postgres mysql

Edit:
Screenshot (248)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

#2372

src/query/src/sql.rs Outdated Show resolved Hide resolved
src/query/src/sql.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #2410 (b1c6073) into develop (ca50ba5) will increase coverage by 6.83%.
Report is 5 commits behind head on develop.
The diff coverage is 68.91%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2410      +/-   ##
===========================================
+ Coverage    77.58%   84.41%   +6.83%     
===========================================
  Files          717      727      +10     
  Lines       112751   115113    +2362     
===========================================
+ Hits         87474    97171    +9697     
+ Misses       25277    17942    -7335     

@killme2008
Copy link
Contributor

@fengjiachun @niebayes PTAL

src/query/src/sql.rs Outdated Show resolved Hide resolved
src/query/src/sql.rs Outdated Show resolved Hide resolved
src/query/src/sql.rs Outdated Show resolved Hide resolved
src/sql/src/parsers/show_parser.rs Outdated Show resolved Hide resolved
src/sql/src/statements/show.rs Outdated Show resolved Hide resolved
@killme2008
Copy link
Contributor

@evenyag PTAL

src/query/src/sql.rs Outdated Show resolved Hide resolved
src/query/src/sql.rs Outdated Show resolved Hide resolved
src/query/src/sql.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

src/query/src/sql.rs Outdated Show resolved Hide resolved
src/query/src/sql.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Sep 22, 2023
@killme2008
Copy link
Contributor

Thank u for your contribution @Lilit0x

Merged via the queue into GreptimeTeam:develop with commit 688e646 Sep 22, 2023
13 checks passed
@killme2008 killme2008 added the docs-required This change requires docs update. label Sep 23, 2023
@killme2008 killme2008 added this to the v0.4 milestone Sep 23, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: added show tables command

* fix(tests): fixed parser and statement unit tests

* chore: implemeted display trait for table type

* fix: handled no tabletype and error for usopprted command in show databse

* chore: removed full as a show kind, instead as a show option

* chore(tests): fixed failing test and added more tests for show full

* chore: refactored table types to use filters

* fix: changed table_type to tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants