fix: fix alter table verification #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
requested review from
MichaelScofield,
fengjiachun,
evenyag and
waynexia
WenyXu
force-pushed
the
fix/verify-alter
branch
2 times, most recently
from
1d96aaa
to
1958e1f
Compare
WenyXu
force-pushed
the
fix/verify-alter
branch
from
1958e1f
to
1cc7a75
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2437 +/- ##
===========================================
- Coverage 77.70% 77.50% -0.21%
===========================================
Files 730 717 -13
Lines 115885 112479 -3406
===========================================
- Hits 90047 87172 -2875
+ Misses 25838 25307 -531 |
MichaelScofield
approved these changes
Sep 19, 2023
Co-authored-by: LFC <990479+MichaelScofield@users.noreply.github.com>
NiwakaDev
reviewed
Sep 19, 2023
Co-authored-by: JeremyHi <jiachun_feng@proton.me>
2 tasks
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* fix: fix verify alter * refactor: move AlterTable UpdateMetadata to last step * refactor: send region request in parallel * Update src/table/src/metadata.rs Co-authored-by: LFC <990479+MichaelScofield@users.noreply.github.com> * Update src/table/src/metadata.rs Co-authored-by: JeremyHi <jiachun_feng@proton.me> --------- Co-authored-by: LFC <990479+MichaelScofield@users.noreply.github.com> Co-authored-by: JeremyHi <jiachun_feng@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Checklist
Refer to a related PR or issue link (optional)
fix #2425