Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update proto and remove create_if_not_exists #2467

Merged

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Sep 21, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR updates proto and removes create_if_not_exists from RegionCreateRequest.

Creating a region needs to be idempotent so create_if_not_exists is always true, we don't need a flag for this.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review September 22, 2023 02:34
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #2467 (7e73530) into develop (6306aea) will decrease coverage by 0.37%.
Report is 3 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2467      +/-   ##
===========================================
- Coverage    84.88%   84.51%   -0.37%     
===========================================
  Files          726      725       -1     
  Lines       115028   115044      +16     
===========================================
- Hits         97638    97232     -406     
- Misses       17390    17812     +422     

@killme2008 killme2008 added this pull request to the merge queue Sep 22, 2023
Merged via the queue into GreptimeTeam:develop with commit c9f8b9c Sep 22, 2023
24 checks passed
@evenyag evenyag deleted the feat/region-create-not-exists branch September 22, 2023 06:21
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants