Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: re-support query engine execute dml #2484

Merged
merged 3 commits into from
Sep 26, 2023
Merged

feat: re-support query engine execute dml #2484

merged 3 commits into from
Sep 26, 2023

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Sep 25, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • Remove calling to table.insert and table.delete, and replace with TableMutationHandler
  • Clean some dead code

Hopefully, after this patch and #2482, #2445 should done

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@zhongzc
feat: re-support query engine execute dml
d6fa072 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc
chore: remove region_number in InsertRequest
c092427 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Merging #2484 (c1734f7) into develop (00272d5) will decrease coverage by 0.27%.
Report is 5 commits behind head on develop.
The diff coverage is 98.94%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2484      +/-   ##
===========================================
- Coverage    84.98%   84.71%   -0.27%     
===========================================
  Files          725      724       -1     
  Lines       115465   115194     -271     
===========================================
- Hits         98123    97591     -532     
- Misses       17342    17603     +261

@waynexia waynexia mentioned this pull request Sep 26, 2023
Merged
2 tasks
waynexia
waynexia approved these changes Sep 26, 2023
View reviewed changes
src/query/src/region_query.rs Show resolved Hide resolved
src/operator/src/statement.rs Show resolved Hide resolved
@waynexia waynexia requested a review from killme2008 September 26, 2023 06:46
killme2008
killme2008 reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! But looks like this PR can't resolve #2445 .

src/query/src/table_mutation.rs Show resolved Hide resolved
@waynexia
Copy link
Member

Good job! But looks like this PR can't resolve #2445 .

needs both this and #2491 to fix

@killme2008
Copy link
Contributor

Good job! But looks like this PR can't resolve #2445 .

needs both this and #2491 to fix

Cool,then we can add back the ignored integration and sqlness tests.

@zhongzc
chore: add doc comments
c1734f7 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
killme2008
killme2008 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Sep 26, 2023
Merged via the queue into GreptimeTeam:develop with commit 0bf2664 Sep 26, 2023
13 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@zhongzc @paomian
feat: re-support query engine execute dml (GreptimeTeam#2484)
afc8493 
* feat: re-support query engine execute dml

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

* chore: remove region_number in InsertRequest

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

* chore: add doc comments

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

---------

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@killme2008 killme2008 killme2008 approved these changes

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhongzc @waynexia @killme2008