fix: print root cause error message to user facing interface #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2486 +/- ##
===========================================
- Coverage 84.97% 84.64% -0.34%
===========================================
Files 725 725
Lines 115463 115466 +3
===========================================
- Hits 98120 97740 -380
- Misses 17343 17726 +383 |
|
@MichaelScofield @shuiyisong is working on improving the error messages. |
|
@shuiyisong please close this PR if you have already changed the error message shown to user, thx. |
|
@MichaelScofield @killme2008 we can merge this pr now to quick fix this issue. I will fine tune error output based on this pr later |
shuiyisong
approved these changes
Sep 25, 2023
sunng87
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
#2428 removes "source" from error, making user facing interfaces (mysql, pg and http) lack of root cause.
Take mysql as an example, selecting an not existed table.
Before:
ERROR 1815 (HY000): Failed to execute query, query: select * from monitor
After:
ERROR 1815 (HY000): Error during planning: Table not found: greptime.public.monitor
Checklist
Refer to a related PR or issue link (optional)