refactor: simplify warn! and error! macros
#2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
evenyag
approved these changes
Sep 26, 2023
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2503 +/- ##
===========================================
- Coverage 84.98% 84.91% -0.08%
===========================================
Files 726 729 +3
Lines 115592 115864 +272
===========================================
+ Hits 98241 98387 +146
- Misses 17351 17477 +126 |
fengjiachun
approved these changes
Sep 27, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* refactor: simplify the error! and warn! macros Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * support display format Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * err.msg to err Signed-off-by: Ruihang Xia <waynestxia@gmail.com> --------- Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Simplify the implementation. Use debug format by default and remove the status code.
Checklist
Refer to a related PR or issue link (optional)
closes #2502