fix(mito): fix region drop task runs multiple times but never clean the dir #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2504 +/- ##
===========================================
- Coverage 85.25% 84.91% -0.35%
===========================================
Files 729 729
Lines 115862 115943 +81
===========================================
- Hits 98780 98449 -331
- Misses 17082 17494 +412 |
waynexia
approved these changes
Sep 27, 2023
killme2008
reviewed
Sep 27, 2023
| } | ||
|
|
||
| // TODO(ruihang): place the marker in a separate dir | ||
| /// Removes region dir if there is no parquet files, returns whether the directory is removed. | ||
| pub(crate) async fn remove_region_dir_once( |
There was a problem hiding this comment.
Adds #[must_use] would be better.
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…he dir (GreptimeTeam#2504) fix: fix region drop task runs multiple times but never clean the directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR fixes the following issues while dropping a region
Versionso the region releases the references to SSTs and purges them.It also adds a test to check whether the region directory is removed as expected.
Checklist
Refer to a related PR or issue link (optional)
closes #2501