Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: push down filters to region engine #2513

Merged

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Sep 27, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Previous TableProviderFilterPushDown::Unsupported prevented pushdown

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc requested review from waynexia and fengjiachun and removed request for waynexia September 27, 2023 13:41
@waynexia waynexia enabled auto-merge September 27, 2023 13:44
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2513 (9a64783) into develop (ccd6de8) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2513      +/-   ##
===========================================
- Coverage    85.33%   84.91%   -0.43%     
===========================================
  Files          729      729              
  Lines       115910   115916       +6     
===========================================
- Hits         98911    98427     -484     
- Misses       16999    17489     +490     

Merged via the queue into GreptimeTeam:develop with commit 7edafc3 Sep 27, 2023
13 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
feat: pushdown filters to region engine

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants