Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: row protocol support for opentsdb #2623

Merged
merged 9 commits into from
Oct 20, 2023
Merged

feat: row protocol support for opentsdb #2623

merged 9 commits into from
Oct 20, 2023

Conversation

Lilit0x
Copy link
Contributor

@Lilit0x Lilit0x commented Oct 18, 2023 •
edited by MichaelScofield
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Support for row inserts in opentsdb

Please explain IN DETAIL what the changes are in this PR and why they are needed:
OpenTSDB now uses the row insert protocol as against column inserts

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

close #2444

MichaelScofield
MichaelScofield reviewed Oct 19, 2023
View reviewed changes
src/servers/src/opentsdb.rs Outdated Show resolved Hide resolved
src/servers/src/opentsdb.rs Outdated Show resolved Hide resolved
src/servers/src/http/opentsdb.rs Show resolved Hide resolved
src/frontend/src/instance/opentsdb.rs Outdated Show resolved Hide resolved
fengjiachun
fengjiachun reviewed Oct 19, 2023
View reviewed changes
src/servers/src/opentsdb.rs Outdated Show resolved Hide resolved
src/servers/src/opentsdb.rs Outdated Show resolved Hide resolved
src/servers/src/opentsdb.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #2623 (7337bcf) into develop (ba15c14) will decrease coverage by 0.26%.
Report is 4 commits behind head on develop.
The diff coverage is 97.36%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2623      +/-   ##
===========================================
- Coverage    85.17%   84.91%   -0.26%     
===========================================
  Files          738      739       +1     
  Lines       119070   119261     +191     
===========================================
- Hits        101413   101266     -147     
- Misses       17657    17995     +338

fengjiachun
fengjiachun approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

src/servers/src/http/opentsdb.rs Show resolved Hide resolved
src/servers/src/http/opentsdb.rs Outdated Show resolved Hide resolved
@waynexia waynexia added this pull request to the merge queue Oct 20, 2023
Merged via the queue into GreptimeTeam:develop with commit 346b57c Oct 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use row protocol to support opentsdb
4 participants
@Lilit0x @MichaelScofield @fengjiachun @waynexia