Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix incorrect COM_STMT_PREPARE reply #3463

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Mar 8, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

fix #3462

What's changed and what's your intention?

fix incorrect COM_STMT_PREPARE reply.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 8, 2024
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But could we add a test case to cover it?

@waynexia
Copy link
Member

waynexia commented Mar 8, 2024

But could we add a test case to cover it?

Maybe add one integration test with sqlx?

@WenyXu
Copy link
Member Author

WenyXu commented Mar 8, 2024

LGTM. But could we add a test case to cover it?

Yes, we can cover this case by using row.get("col_name");;

@WenyXu WenyXu marked this pull request as draft March 8, 2024 07:14
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.07%. Comparing base (3f3ef2e) to head (6f245e5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3463      +/-   ##
==========================================
- Coverage   85.41%   85.07%   -0.34%     
==========================================
  Files         896      896              
  Lines      147185   147532     +347     
==========================================
- Hits       125711   125507     -204     
- Misses      21474    22025     +551     

@WenyXu WenyXu marked this pull request as ready for review March 8, 2024 07:20
@v0y4g3r v0y4g3r enabled auto-merge March 8, 2024 07:22
@v0y4g3r v0y4g3r added this pull request to the merge queue Mar 8, 2024
Merged via the queue into GreptimeTeam:main with commit a309cd0 Mar 8, 2024
21 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems the num_columns in COM_STMT_PREPARE_OK always returns zero
4 participants