Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decoding prometheus remote write proto doesn't reset the value #3505

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

closes #3495

What's changed and what's your intention?

Clear::clear() of Sample used to be an empty impl and causes incorrect data.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested a review from v0y4g3r March 13, 2024 16:35
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 13, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.93%. Comparing base (e433396) to head (038bc4f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3505      +/-   ##
==========================================
- Coverage   85.34%   84.93%   -0.42%     
==========================================
  Files         904      904              
  Lines      150172   150170       -2     
==========================================
- Hits       128169   127541     -628     
- Misses      22003    22629     +626     

@waynexia waynexia enabled auto-merge March 14, 2024 02:50
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Mar 14, 2024
Merged via the queue into GreptimeTeam:main with commit b85d7bb Mar 14, 2024
30 checks passed
@waynexia waynexia deleted the fix-proto-clear branch March 14, 2024 03:21
@evenyag evenyag mentioned this pull request Mar 14, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent and incorrect behaviour when writing zero-value metrics with Prometheus remote write
4 participants