Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: batch alter logical tables #3569

Merged
merged 6 commits into from
Mar 26, 2024
Merged

feat: batch alter logical tables #3569

merged 6 commits into from
Mar 26, 2024

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As the title said

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@fengjiachun fengjiachun marked this pull request as draft March 23, 2024 10:44
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 23, 2024
@fengjiachun fengjiachun force-pushed the feat/alter-logical-tables branch 2 times, most recently from 6428f0c to 38c70a7 Compare March 24, 2024 09:54
@fengjiachun fengjiachun marked this pull request as ready for review March 24, 2024 09:54
@fengjiachun fengjiachun force-pushed the feat/alter-logical-tables branch 2 times, most recently from 4550b6a to 6f1876b Compare March 24, 2024 13:51
@codecov Codecov
Copy link

codecov bot commented Mar 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.84345% with 179 lines in your changes are missing coverage. Please review.

Project coverage is 84.84%. Comparing base (bf14d33) to head (5606334).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3569      +/-   ##
==========================================
- Coverage   85.25%   84.84%   -0.41%     
==========================================
  Files         917      924       +7     
  Lines      152869   153487     +618     
==========================================
- Hits       130324   130231      -93     
- Misses      22545    23256     +711

@fengjiachun
Copy link
Collaborator Author

After #3570

@fengjiachun fengjiachun force-pushed the feat/alter-logical-tables branch 2 times, most recently from 1c2fd3c to 1d5b7b6 Compare March 25, 2024 13:07
waynexia
waynexia reviewed Mar 26, 2024
View reviewed changes
src/common/meta/src/ddl/alter_table.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/table_route.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/alter_logical_tables/check.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/alter_logical_tables/check.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/alter_logical_tables/metadata.rs Show resolved Hide resolved
src/common/meta/src/ddl/alter_logical_tables/metadata.rs Outdated Show resolved Hide resolved
fengjiachun and others added 2 commits March 26, 2024 13:49
@fengjiachun @waynexia
Update src/common/meta/src/ddl/alter_table.rs
2c6018c 
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
@fengjiachun
feat: add some comments
ca5fc39
waynexia
waynexia approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Mar 26, 2024
Merged via the queue into GreptimeTeam:main with commit c2dd113 Mar 26, 2024
19 checks passed
@fengjiachun fengjiachun deleted the feat/alter-logical-tables branch March 26, 2024 07:20
@tisonkun tisonkun mentioned this pull request Apr 9, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@WenyXu WenyXu WenyXu approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fengjiachun @waynexia @WenyXu