-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support outputting various date styles for postgresql #3602
Conversation
@MichaelScofield Could you review this pr? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3602 +/- ##
==========================================
- Coverage 85.41% 85.06% -0.36%
==========================================
Files 932 934 +2
Lines 155075 155479 +404
==========================================
- Hits 132451 132251 -200
- Misses 22624 23228 +604 |
@MichaelScofield any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test cases are solid.
@MichaelScofield I'm going to merge this. If you have any other suggestions, you could comment on this PR or the related issue. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
close #3442
What's changed and what's your intention?
Support outputting various date styles for postgresql
Please explain IN DETAIL what the changes are in this PR and why they are needed:
StylingDate
andStylingDateTime
to encode date into related styleConfigurationVariables
Checklist