refactor(flow): func spec api&use Error not EvalError in mfp #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
discord9
force-pushed
the
flow_p3_refactor
branch
from
13581ca
to
4ff61f2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3657 +/- ##
==========================================
- Coverage 85.16% 84.88% -0.29%
==========================================
Files 949 950 +1
Lines 158673 158736 +63
==========================================
- Hits 135131 134736 -395
- Misses 23542 24000 +458 |
discord9
force-pushed
the
flow_p3_refactor
branch
from
2d33f3f
to
c6c4854
Compare
zhongzc
reviewed
Apr 8, 2024
zhongzc
reviewed
Apr 8, 2024
zhongzc
reviewed
Apr 8, 2024
discord9
force-pushed
the
flow_p3_refactor
branch
from
c1b9023
to
52b70c4
Compare
zhongzc
reviewed
Apr 8, 2024
zhongzc
reviewed
Apr 8, 2024
zhongzc
approved these changes
Apr 8, 2024
tisonkun
approved these changes
Apr 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@discord9 There is a compile error. |
|
wired, will fix it soon |
discord9
force-pushed
the
flow_p3_refactor
branch
from
81b3d77
to
9162796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
!!! DO NOT LEAVE THIS BLOCK EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Make some changes to various types to make them easy to use.
*Functionto choose what specialized function to use when input types are known.signatureto have multiple input and refine defining signatures with macroErrorforMapFilterProject's method that should only be called when building a dataflow graphmap,projectionandfilterforTypedPlansince they are commonly used in building those plan from substraitChecklist