refactor: pass http method to metasrv http handler #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
changed the title
github-actions
bot
added
Invalid PR Title
docs-not-required
tisonkun
changed the title
tisonkun
force-pushed
the
refactor-http-method-metasrv-http
branch
from
5c6de1a
to
d2eed19
Compare
nicecui
reviewed
Apr 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3667 +/- ##
==========================================
- Coverage 85.16% 84.84% -0.32%
==========================================
Files 943 949 +6
Lines 157235 158718 +1483
==========================================
+ Hits 133911 134672 +761
- Misses 23324 24046 +722 |
nicecui
approved these changes
Apr 9, 2024
killme2008
approved these changes
Apr 9, 2024
Co-authored-by: dennis zhuang <killme2008@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Spotted on GreptimeTeam/docs#878.
This follows up #3527
Checklist