-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: bundle the lightweight axum test client #3669
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3669 +/- ##
==========================================
- Coverage 85.15% 84.83% -0.33%
==========================================
Files 949 950 +1
Lines 158555 158795 +240
==========================================
- Hits 135022 134709 -313
- Misses 23533 24086 +553 |
Signed-off-by: tison <wander4096@gmail.com>
4de2fdb
to
9380c4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Almostly
@killme2008 all resolved. |
Signed-off-by: tison <wander4096@gmail.com>
05ecf84
to
5c810af
Compare
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This is a thin HTTP client (see tokio-rs/axum#1146 (comment)) so we can drop one unnecessary dep. The upstream of axum-test-helper is not quite active so it may stop us from upgrading other deps. See cloudwalk/axum-test-helper#29.
Checklist