Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove global_ttl config #3673

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Apr 8, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR removes the global_ttl config item since its no longer used.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@v0y4g3r v0y4g3r requested review from evenyag and waynexia April 8, 2024 13:28
@github-actions github-actions bot added the docs-required This change requires docs update. label Apr 8, 2024
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.83%. Comparing base (fe1a010) to head (8d56bab).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3673      +/-   ##
==========================================
- Coverage   85.14%   84.83%   -0.31%     
==========================================
  Files         943      949       +6     
  Lines      157070   158554    +1484     
==========================================
+ Hits       133733   134515     +782     
- Misses      23337    24039     +702     

@sunng87
Copy link
Member

sunng87 commented Apr 8, 2024

Is this a breaking change?

@killme2008
Copy link
Contributor

Is this a breaking change?

Already broken in v0.4

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Apr 9, 2024
Merged via the queue into GreptimeTeam:main with commit 183fccb Apr 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants