Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup todos that should be panic #3720

Merged

Conversation

tisonkun
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

TRIVIAL AS IS.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@tisonkun tisonkun requested a review from a team as a code owner April 16, 2024 13:00
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 16, 2024
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun force-pushed the clear-todos-should-be-panic branch from 723ac82 to b101c37 Compare April 16, 2024 13:01
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 85.16%. Comparing base (d123791) to head (b101c37).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3720      +/-   ##
==========================================
- Coverage   85.44%   85.16%   -0.29%     
==========================================
  Files         966      966              
  Lines      162087   162087              
==========================================
- Hits       138496   138039     -457     
- Misses      23591    24048     +457     

@MichaelScofield MichaelScofield added this pull request to the merge queue Apr 17, 2024
Merged via the queue into GreptimeTeam:main with commit 786f43d Apr 17, 2024
19 checks passed
@tisonkun tisonkun deleted the clear-todos-should-be-panic branch May 3, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants