Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preserve arg to sqlness runner #3724

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Apr 17, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Add --preserve-state CLI arg to prevent temp dir from cleaning on exit. Sqlness runner in CI will use it to preserve logs and state.

Use tempdir because tempfile cannot set a prefix on temp dir.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested a review from a team as a code owner April 17, 2024 03:41
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 17, 2024
tests/runner/src/main.rs Outdated Show resolved Hide resolved
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested a review from evenyag April 17, 2024 03:53
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.12%. Comparing base (3e9bda3) to head (2095dae).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3724      +/-   ##
==========================================
- Coverage   85.43%   85.12%   -0.31%     
==========================================
  Files         966      966              
  Lines      162088   162088              
==========================================
- Hits       138482   137984     -498     
- Misses      23606    24104     +498     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun
Copy link
Collaborator

@waynexia sqlness test failed

@waynexia
Copy link
Member Author

Do you have any idea about the compatibility test @MichaelScofield ? It now relies on "dirty sqlness state", which is a bug IMHO. I'm going to comment out that test until we find a better way to test the compatibility

@waynexia
Copy link
Member Author

E.g.: maintain a dedicated Python script to create tables and write data into two versions and compare them.

@killme2008 killme2008 added this pull request to the merge queue Apr 22, 2024
Merged via the queue into GreptimeTeam:main with commit d0b2a11 Apr 22, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants