Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support invalidate schema name key cache #3725

Merged
merged 4 commits into from
Apr 18, 2024
Merged

feat: support invalidate schema name key cache #3725

merged 4 commits into from
Apr 18, 2024

Conversation

poltao
Copy link
Contributor

@poltao poltao commented Apr 17, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #3695

What's changed and what's your intention?

CacheInvalidator Trait adds processing for a new CacheIdent Enum SchemaName. After dropping database, we can invalidate schema_key.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@poltao poltao requested review from MichaelScofield and a team as code owners April 17, 2024 05:32
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 17, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.14%. Comparing base (7e56bf2) to head (089f1d3).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3725      +/-   ##
==========================================
- Coverage   85.42%   85.14%   -0.29%     
==========================================
  Files         966      966              
  Lines      162097   162195      +98     
==========================================
- Hits       138472   138096     -376     
- Misses      23625    24099     +474

@fengjiachun fengjiachun requested a review from WenyXu April 17, 2024 06:00
WenyXu
WenyXu approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/common/meta/src/ddl/drop_database/metadata.rs Outdated Show resolved Hide resolved
@MichaelScofield MichaelScofield added this pull request to the merge queue Apr 18, 2024
Merged via the queue into GreptimeTeam:main with commit 4248dfc Apr 18, 2024
19 checks passed
@poltao poltao deleted the invalidate branch April 18, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalidate schema name key cache after dropping database
3 participants
@poltao @MichaelScofield @WenyXu