Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tinytext, mediumtext and longtext data types #3731

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

CookiePieWw
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #3703

What's changed and what's your intention?

Add TINYTEXT, MEDIUMTEXT and LONGTEXT as alias of TEXT for compatibility with MYSQL.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@CookiePieWw CookiePieWw requested a review from a team as a code owner April 17, 2024 16:36
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (7e56bf2) to head (f3c80af).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3731      +/-   ##
==========================================
- Coverage   85.42%   85.15%   -0.27%     
==========================================
  Files         966      966              
  Lines      162097   162116      +19     
==========================================
- Hits       138472   138052     -420     
- Misses      23625    24064     +439     

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified locally also:

mysql> CREATE TABLE t(ts TIMESTAMP TIME INDEX, payload MEDIUMTEXT);
Query OK, 0 rows affected (0.02 sec)

mysql> DESC t;
+---------+----------------------+------+------+---------+---------------+
| Column  | Type                 | Key  | Null | Default | Semantic Type |
+---------+----------------------+------+------+---------+---------------+
| ts      | TimestampMillisecond | PRI  | NO   |         | TIMESTAMP     |
| payload | String               |      | YES  |         | FIELD         |
+---------+----------------------+------+------+---------+---------------+
2 rows in set (0.01 sec)

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun tisonkun added this pull request to the merge queue Apr 18, 2024
Merged via the queue into GreptimeTeam:main with commit 6494553 Apr 18, 2024
20 checks passed
@tisonkun
Copy link
Contributor

Thanks for your contribution @CookiePieWw! This patch is clean and correct :D

@CookiePieWw CookiePieWw deleted the add-text-types branch April 19, 2024 16:44
tisonkun added a commit to GreptimeTeam/docs that referenced this pull request May 14, 2024
This reflects the change introduced by GreptimeTeam/greptimedb#3731.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TEXT type in MySQL codepath or core SQL path
3 participants