Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow): flow runtime render reduce operator #3736

Closed
wants to merge 13 commits into from

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Apr 18, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Add functionalitiy to render reduce operator, i.e. simple aggregate functions
Also refactor render.rs into smaller files:

  • impl render_reduce which support distinct and basic aggr functions
  • split render.rs into smaller files

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 18, 2024
@discord9 discord9 marked this pull request as ready for review April 18, 2024 11:03
@discord9 discord9 requested review from zhongzc, waynexia and a team as code owners April 18, 2024 11:03
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 93.00080% with 87 lines in your changes are missing coverage. Please review.

Project coverage is 85.19%. Comparing base (20e8c3d) to head (f377499).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3736      +/-   ##
==========================================
- Coverage   85.46%   85.19%   -0.27%     
==========================================
  Files         966      968       +2     
  Lines      162211   163167     +956     
==========================================
+ Hits       138630   139008     +378     
- Misses      23581    24159     +578     

@discord9 discord9 marked this pull request as draft April 19, 2024 06:45
@discord9 discord9 closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants