Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: post process result on query full column name of prom labels API #3793

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

/labels without matcher is handled in another way. This patch fixes the incorrect behavior of two cases.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested a review from yuanbohan April 24, 2024 08:30
@waynexia waynexia requested a review from a team as a code owner April 24, 2024 08:30
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 24, 2024
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yuanbohan yuanbohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia marked this pull request as draft April 24, 2024 08:40
auto-merge was automatically disabled April 24, 2024 08:40

Pull request was converted to draft

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.27%. Comparing base (42e7403) to head (e5461cf).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3793      +/-   ##
==========================================
- Coverage   85.59%   85.27%   -0.32%     
==========================================
  Files         947      947              
  Lines      160612   161503     +891     
==========================================
+ Hits       137482   137729     +247     
- Misses      23130    23774     +644     

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia marked this pull request as ready for review April 24, 2024 09:25
@waynexia waynexia enabled auto-merge April 24, 2024 09:28
@waynexia waynexia added this pull request to the merge queue Apr 24, 2024
Merged via the queue into GreptimeTeam:main with commit 1272bc9 Apr 24, 2024
19 of 32 checks passed
@waynexia waynexia deleted the fix-label-query branch April 24, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants