Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: log statement on error by Display #3803

Merged
merged 2 commits into from
Apr 26, 2024
Merged

refactor: log statement on error by Display #3803

merged 2 commits into from
Apr 26, 2024

Conversation

tisonkun
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This is a follow-up to #3646 and thus #3744 and #3792.

This can be related to #2144.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@tisonkun tisonkun requested a review from a team as a code owner April 25, 2024 19:30
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 25, 2024
@tisonkun
refactor: log statement on error by Display
cd5068f 
Signed-off-by: tison <wander4096@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Apr 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.30%. Comparing base (1ec5951) to head (bc4932c).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3803      +/-   ##
==========================================
- Coverage   85.64%   85.30%   -0.34%     
==========================================
  Files         953      953              
  Lines      162881   162835      -46     
==========================================
- Hits       139501   138910     -591     
- Misses      23380    23925     +545

evenyag
evenyag approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/frontend/src/instance.rs Outdated Show resolved Hide resolved
src/frontend/src/instance/prom_store.rs Outdated Show resolved Hide resolved
src/servers/src/query_handler/sql.rs Outdated Show resolved Hide resolved
@tisonkun @evenyag
Apply suggestions from code review
bc4932c 
Co-authored-by: Yingwen <realevenyag@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun added this pull request to the merge queue Apr 26, 2024
Merged via the queue into GreptimeTeam:main with commit 4eadd9f Apr 26, 2024
18 checks passed
@tisonkun tisonkun deleted the logstmt branch April 26, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@evenyag evenyag evenyag approved these changes

@killme2008 killme2008 Awaiting requested review from killme2008

@sunng87 sunng87 Awaiting requested review from sunng87

@waynexia waynexia Awaiting requested review from waynexia

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tisonkun @MichaelScofield @evenyag