Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: count_wildcard_to_time_index_rule doesn't handle table reference properly #3847

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Fix regressions from #3845

What's changed and what's your intention?

Use TableReference to avoid unexpected canonicalization. And check if the time index column is valid at the plan to use it.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested review from evenyag and a team as code owners April 30, 2024 15:25
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 30, 2024
@waynexia waynexia enabled auto-merge April 30, 2024 15:37
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.30%. Comparing base (e84b1ee) to head (8cd300b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3847      +/-   ##
==========================================
- Coverage   85.58%   85.30%   -0.29%     
==========================================
  Files         955      955              
  Lines      163426   163467      +41     
==========================================
- Hits       139872   139438     -434     
- Misses      23554    24029     +475     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I need a coffee, you are welcome :D.

@waynexia waynexia added this pull request to the merge queue Apr 30, 2024
Merged via the queue into GreptimeTeam:main with commit e6eca8c Apr 30, 2024
22 checks passed
@waynexia waynexia deleted the fix-wildcard branch April 30, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants