Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: avoid trying to send slack notification in forks #3857

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented May 6, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Although forks can disable this workflow at all, let's try to skip this step because forks doesn't have the secrets: https://github.com/tisonkun/greptimedb/actions/runs/8962181455/job/24610696840

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@tisonkun tisonkun requested a review from a team as a code owner May 6, 2024 00:22
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.59%. Comparing base (73fe075) to head (b3632ab).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3857      +/-   ##
==========================================
- Coverage   85.60%   85.59%   -0.01%     
==========================================
  Files         955      955              
  Lines      163262   163262              
==========================================
- Hits       139761   139752       -9     
- Misses      23501    23510       +9     

@tisonkun tisonkun requested a review from zyy17 May 6, 2024 02:21
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 9c3b960 May 6, 2024
23 checks passed
@v0y4g3r v0y4g3r deleted the tisonkun-patch-1 branch May 6, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants