Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove re-export from logging #3865

Merged
merged 4 commits into from
May 6, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented May 6, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Remove re-export of info!, debug! etc from common_telemetry::logging. Change all logging::info!() to info!() correspondingly.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 6, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 85.25%. Comparing base (573c19b) to head (ae3a46e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3865      +/-   ##
==========================================
- Coverage   85.56%   85.25%   -0.31%     
==========================================
  Files         952      952              
  Lines      163062   163062              
==========================================
- Hits       139531   139026     -505     
- Misses      23531    24036     +505     

Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DLJB

@tisonkun tisonkun added this pull request to the merge queue May 6, 2024
Merged via the queue into GreptimeTeam:main with commit 5303537 May 6, 2024
21 checks passed
@fengjiachun
Copy link
Collaborator

LGTM

@waynexia waynexia deleted the logging-organize branch May 7, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants