Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid double future #3890

Merged
merged 1 commit into from
May 9, 2024

Conversation

fengjiachun
Copy link
Collaborator

@fengjiachun fengjiachun commented May 9, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As the title said, the tables API does nod need to be an async method since it return a BoxStream

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@fengjiachun fengjiachun requested a review from a team as a code owner May 9, 2024 06:54
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 9, 2024
@waynexia waynexia enabled auto-merge May 9, 2024 07:05
@waynexia waynexia added this pull request to the merge queue May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.30%. Comparing base (0e05f85) to head (729552e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3890      +/-   ##
==========================================
- Coverage   85.65%   85.30%   -0.36%     
==========================================
  Files         952      952              
  Lines      163607   163558      -49     
==========================================
- Hits       140145   139522     -623     
- Misses      23462    24036     +574     

Merged via the queue into GreptimeTeam:main with commit f995f60 May 9, 2024
22 checks passed
@fengjiachun fengjiachun deleted the chore/fix-double-future branch May 9, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants