feat: support compression on gRPC server #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuiyisong
requested review from
sunng87,
MichaelScofield,
fengjiachun and
waynexia
github-actions
bot
added
docs-required
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3961 +/- ##
==========================================
- Coverage 85.45% 85.16% -0.30%
==========================================
Files 977 977
Lines 169275 169277 +2
==========================================
- Hits 144655 144161 -494
- Misses 24620 25116 +496 |
fengjiachun
approved these changes
May 17, 2024
sunng87
reviewed
May 17, 2024
shuiyisong
force-pushed
the
feat/grpc_server_gzip
branch
from
a26dc06
to
74e66ee
Compare
tisonkun
reviewed
May 20, 2024
tisonkun
approved these changes
May 20, 2024
github-actions
bot
added
docs-not-required
waynexia
approved these changes
May 20, 2024
WenyXu
pushed a commit
to WenyXu/greptimedb
that referenced
this pull request
May 21, 2024
* feat: enable gzip in grpc server side * feat: add enable_gzip_compression config * test: add grpc compression test * feat: support user configured compression on grpc server * chore: update doc * chore: add tests * fix: make config-docs * chore: fix cr issue * chore: add test * refactor: remove config on server side, auto enable all compression support * chore: minor update * chore: remove unused code * refactor: enable zstd compression internally by default * chore: minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This pr mainly supports gRPC server compression encoding options(
gzip,zstd). Now gRPC server is allowed to receive requests with such encoding.In this pr we also enable zstd compression encoding by default between frontend and datanode.
Checklist