-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace Expr with datafusion::Expr #3995
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3995 +/- ##
==========================================
- Coverage 85.48% 85.15% -0.33%
==========================================
Files 977 977
Lines 169348 169323 -25
==========================================
- Hits 144773 144195 -578
- Misses 24575 25128 +553 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! @realtaobo I have linked this PR to the issue's task list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still many alias DfExpr
, but this PR is good to go
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
as title, part of #3884
What's changed and what's your intention?
Checklist