Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fallback logic for vmagent sending wrong content type #4009

Merged
merged 3 commits into from
May 23, 2024

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented May 21, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Fixes #3929

What's changed and what's your intention?

Added fallback logic to handle situation when vmagent send wrong content type of data.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@sunng87 sunng87 requested a review from a team as a code owner May 21, 2024 23:23
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.19%. Comparing base (a1c51a5) to head (854f08f).
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4009      +/-   ##
==========================================
- Coverage   85.61%   85.19%   -0.43%     
==========================================
  Files         972      980       +8     
  Lines      166840   170117    +3277     
==========================================
+ Hits       142838   144928    +2090     
- Misses      24002    25189    +1187     

src/servers/src/http/prom_store.rs Outdated Show resolved Hide resolved
Co-authored-by: Yingwen <realevenyag@gmail.com>
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyy17 zyy17 added this pull request to the merge queue May 23, 2024
Merged via the queue into GreptimeTeam:main with commit b90b7ad May 23, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vmagent could send remote-write requests in Snappy compression after the VM protocol handshake
3 participants