Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: round-robin selector #4024

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Implement RoundRobin Selector which selects peers in a completely fair way.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 96.94656% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.16%. Comparing base (4778575) to head (8601552).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4024      +/-   ##
==========================================
- Coverage   85.50%   85.16%   -0.34%     
==========================================
  Files         977      981       +4     
  Lines      169344   170256     +912     
==========================================
+ Hits       144793   144998     +205     
- Misses      24551    25258     +707     

@waynexia waynexia added this pull request to the merge queue May 24, 2024
Merged via the queue into GreptimeTeam:main with commit a58256d May 24, 2024
30 checks passed
@waynexia waynexia deleted the round-robin-selector branch May 24, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants