Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement WalEntryDistributor, WalEntryReceiver #4031

Merged
merged 4 commits into from
May 31, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 24, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4026

What's changed and what's your intention?

  1. Implement the WalEntryDistributor, which reads and raw WAL entries from the topic and distributes them to WalEntryReceiver based on RegionId and start_id.
  2. Implement the WalEntryReceiver, which receives raw WAL entries from the WalEntryDistributor, and decodes raw WAL entries into upper-level WAL entries.

wait for #4038

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 24, 2024
@WenyXu WenyXu marked this pull request as draft May 24, 2024 07:16
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 98.46449% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 85.23%. Comparing base (eab309f) to head (20ca37d).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4031      +/-   ##
==========================================
- Coverage   85.34%   85.23%   -0.12%     
==========================================
  Files         987      991       +4     
  Lines      172109   172933     +824     
==========================================
+ Hits       146893   147403     +510     
- Misses      25216    25530     +314     

@WenyXu WenyXu marked this pull request as ready for review May 24, 2024 08:29
@WenyXu WenyXu changed the title feat: implement the LogStoreEntryReader feat: implement the LogStoreEntryReader and WalEntryDistributor , WalEntryReciver May 24, 2024
@WenyXu WenyXu changed the title feat: implement the LogStoreEntryReader and WalEntryDistributor , WalEntryReciver feat: implement the LogStoreEntryReader and WalEntryDistributor, WalEntryReciver May 24, 2024
src/mito2/src/wal/entry_distributor.rs Outdated Show resolved Hide resolved
src/mito2/src/wal/entry_distributor.rs Show resolved Hide resolved
src/mito2/src/wal/entry_distributor.rs Outdated Show resolved Hide resolved
src/mito2/src/wal/entry_distributor.rs Outdated Show resolved Hide resolved
src/mito2/src/wal/entry_distributor.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu marked this pull request as draft May 24, 2024 12:29
@WenyXu WenyXu changed the title feat: implement the LogStoreEntryReader and WalEntryDistributor, WalEntryReciver feat: implement WalEntryDistributor, WalEntryReciver May 30, 2024
@WenyXu WenyXu marked this pull request as ready for review May 30, 2024 07:23
src/mito2/src/wal/entry_distributor.rs Outdated Show resolved Hide resolved
src/mito2/src/wal/entry_distributor.rs Outdated Show resolved Hide resolved
src/mito2/src/wal/entry_distributor.rs Outdated Show resolved Hide resolved
src/mito2/src/wal/entry_distributor.rs Outdated Show resolved Hide resolved
src/mito2/src/wal/entry_distributor.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue May 31, 2024
Merged via the queue into GreptimeTeam:main with commit fcfcf86 May 31, 2024
28 checks passed
@WenyXu WenyXu changed the title feat: implement WalEntryDistributor, WalEntryReciver feat: implement WalEntryDistributor, WalEntryReceiver Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants