Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support gRPC cancellation #4092

Merged
merged 5 commits into from
Jun 6, 2024
Merged

feat: support gRPC cancellation #4092

merged 5 commits into from
Jun 6, 2024

Conversation

fengjiachun
Copy link
Collaborator

@fengjiachun fengjiachun commented Jun 3, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR enables gRPC server cancellation support in RegionServer and GreptimeService.

Closes #3964

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@fengjiachun fengjiachun requested a review from a team as a code owner June 3, 2024 04:23
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 3, 2024
@fengjiachun fengjiachun requested a review from waynexia June 3, 2024 04:31
@fengjiachun fengjiachun force-pushed the feat/cancellation-grpc branch 2 times, most recently from 76f4ef3 to 2d2d75d Compare June 3, 2024 04:48
@codecov Codecov
Copy link

codecov bot commented Jun 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.70588% with 54 lines in your changes missing coverage. Please review.

Project coverage is 85.15%. Comparing base (b03cb38) to head (06c15b2).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4092      +/-   ##
==========================================
- Coverage   85.48%   85.15%   -0.33%     
==========================================
  Files         993      994       +1     
  Lines      173724   173825     +101     
==========================================
- Hits       148511   148028     -483     
- Misses      25213    25797     +584

waynexia
waynexia approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My 5th time forgetting about the relationship of Datanode, RegionInvoker and RegionServer

@waynexia waynexia enabled auto-merge June 6, 2024 08:11
@fengjiachun
Copy link
Collaborator Author

My 5th time forgetting about the relationship of Datanode, RegionInvoker and RegionServer

Me too, cc @WenyXu

@waynexia waynexia added this pull request to the merge queue Jun 6, 2024
Merged via the queue into GreptimeTeam:main with commit 4719569 Jun 6, 2024
28 checks passed
@fengjiachun fengjiachun deleted the feat/cancellation-grpc branch July 4, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@WenyXu WenyXu Awaiting requested review from WenyXu

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Propagate cancellation from client to datanode
3 participants
@fengjiachun @waynexia @WenyXu