Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common-macro): remove features covered by full #4131

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Jun 11, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4130

What's changed and what's your intention?

A very small fix. We already enabled the full features and it includes most features we listed in the Cargo.toml.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@evenyag evenyag requested a review from sunng87 June 11, 2024 06:59
@evenyag evenyag marked this pull request as ready for review June 11, 2024 06:59
@evenyag evenyag requested a review from a team as a code owner June 11, 2024 06:59
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (587e99d) to head (7958404).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4131      +/-   ##
==========================================
- Coverage   85.46%   85.13%   -0.33%     
==========================================
  Files         994      994              
  Lines      174348   174348              
==========================================
- Hits       149005   148435     -570     
- Misses      25343    25913     +570     

@tisonkun tisonkun added this pull request to the merge queue Jun 11, 2024
Merged via the queue into GreptimeTeam:main with commit 5533bd9 Jun 11, 2024
46 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants