Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly set config instead of using changable default in tests #4132

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

fix #4126

What's changed and what's your intention?

fix the test failure in #4126

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@MichaelScofield MichaelScofield requested a review from a team as a code owner June 11, 2024 07:13
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (587e99d) to head (f2fa4cd).
Report is 2 commits behind head on main.

Current head f2fa4cd differs from pull request most recent head 48d5d1d

Please upload reports for the commit 48d5d1d to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4132      +/-   ##
==========================================
- Coverage   85.46%   85.13%   -0.33%     
==========================================
  Files         994      994              
  Lines      174348   174348              
==========================================
- Hits       149005   148436     -569     
- Misses      25343    25912     +569     

@tisonkun
Copy link
Contributor

Does this mean that the default value is improper and we should revisit them later? Or just the one for this scenario need tunning.

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag
Copy link
Contributor

evenyag commented Jun 11, 2024

Does this mean that the default value is improper and we should revisit them later?

No. These default options are auto-tunable. They depend on the total memory and cores of the host machine running the test. We can't assert the value of the default option with a fixed value in the example config file.

@MichaelScofield MichaelScofield added this pull request to the merge queue Jun 11, 2024
Merged via the queue into GreptimeTeam:main with commit 9473daa Jun 11, 2024
41 checks passed
@MichaelScofield MichaelScofield deleted the 4126-workflow-run-release-failed branch June 11, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow run 'Release' failed
3 participants