Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused code #4135

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jun 12, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Clean up TODO comments and remove unused code

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 12, 2024
src/mito2/src/wal/entry_reader.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.20%. Comparing base (65f8b72) to head (46c0b7d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4135      +/-   ##
==========================================
- Coverage   85.47%   85.20%   -0.28%     
==========================================
  Files         994      994              
  Lines      174947   174942       -5     
==========================================
- Hits       149537   149056     -481     
- Misses      25410    25886     +476     

Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
@tisonkun tisonkun added this pull request to the merge queue Jun 12, 2024
Merged via the queue into GreptimeTeam:main with commit 14a2d83 Jun 12, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants