Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add guide for tsbs benchmark #4151

Merged
merged 3 commits into from
Jun 16, 2024
Merged

docs: add guide for tsbs benchmark #4151

merged 3 commits into from
Jun 16, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Jun 15, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

https://github.com/orgs/GreptimeTeam/discussions/4150

What's changed and what's your intention?

Add the manual to run and reproduce our TSBS benchmark.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@waynexia
docs: add guide for tsbs benchmark
c1934e9 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia
fix typo
7fba9ab 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested a review from a team as a code owner June 15, 2024 14:59
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 15, 2024
@waynexia waynexia requested a review from evenyag June 15, 2024 15:00
@waynexia waynexia enabled auto-merge June 15, 2024 18:15
killme2008
killme2008 approved these changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 disabled auto-merge June 16, 2024 00:05
@killme2008 killme2008 disabled auto-merge June 16, 2024 00:06
@killme2008 killme2008 disabled auto-merge June 16, 2024 00:07
@killme2008
Copy link
Contributor

Looks wired:

Sqlness Test (Basic) Expected — Waiting for status to be reported
Required
Sqlness Test (Remote WAL) Expected — Waiting for status to be reported

@waynexia waynexia disabled auto-merge June 16, 2024 08:01
@waynexia waynexia merged commit a2e3532 into GreptimeTeam:main Jun 16, 2024
8 checks passed
@waynexia waynexia deleted the tsbs-guide branch June 16, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 approved these changes

@evenyag evenyag evenyag approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waynexia @killme2008 @evenyag