Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make RegionScanner aware of PartitionRange #4170

Merged
merged 15 commits into from
Jun 21, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Jun 19, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This is the first part of a parallel table scan with configurable ordering optimization.

Things left to do in the follow-up PRs:

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested review from v0y4g3r, evenyag and a team as code owners June 19, 2024 08:21
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 19, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 79.19463% with 62 lines in your changes missing coverage. Please review.

Project coverage is 84.77%. Comparing base (cc2f7ef) to head (c0e0c56).
Report is 9 commits behind head on main.

Current head c0e0c56 differs from pull request most recent head 4efb506

Please upload reports for the commit 4efb506 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4170      +/-   ##
==========================================
- Coverage   85.12%   84.77%   -0.35%     
==========================================
  Files        1020     1023       +3     
  Lines      179635   180087     +452     
==========================================
- Hits       152920   152675     -245     
- Misses      26715    27412     +697     

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/common/recordbatch/src/util.rs Outdated Show resolved Hide resolved
src/mito2/src/read/seq_scan.rs Outdated Show resolved Hide resolved
src/store-api/src/region_engine.rs Show resolved Hide resolved
src/table/src/table/scan.rs Outdated Show resolved Hide resolved
src/mito2/src/read/seq_scan.rs Show resolved Hide resolved
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia enabled auto-merge June 21, 2024 09:39
@waynexia waynexia added this pull request to the merge queue Jun 21, 2024
Merged via the queue into GreptimeTeam:main with commit fce65c9 Jun 21, 2024
48 checks passed
@waynexia waynexia deleted the partition-range branch June 21, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants