fix: align workflows again for the troublesome GHA #4196
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4196 +/- ##
==========================================
- Coverage 85.04% 84.75% -0.29%
==========================================
Files 1027 1031 +4
Lines 180210 181303 +1093
==========================================
+ Hits 153258 153669 +411
- Misses 26952 27634 +682 |
|
I updated the branch protection settings so we don't need to update the yaml now. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/docs.yml (1 hunks)
Additional comments not posted (2)
.github/workflows/docs.yml (2)
70-70: Dynamic job name based on matrix configuration.This change allows the job name to dynamically reflect the mode being tested, enhancing clarity and traceability in CI logs.
70-70: Ensure compatibility with existing CI configurations.The change to a dynamic job name should be checked for compatibility with any scripts or tools that depend on static job names.
Verification successful
Ensure compatibility with existing CI configurations.
The change to a dynamic job name has been verified, and no dependencies on the old static job name 'Sqlness Test (Basic)' were found in the repository.
- No occurrences of 'Sqlness Test (Basic)' were found in
.github/workflows.- No occurrences of 'Sqlness Test (Basic)' were found in the entire repository.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Ensure that no scripts rely on the static job name 'Sqlness Test (Basic)'. # Test: Search for the old job name in the repository. Expect: No occurrences. rg --type yaml $'Sqlness Test \\(Basic\\)' .github/workflowsLength of output: 59
Script:
#!/bin/bash # Description: Ensure that no scripts, documentation, or configuration files rely on the static job name 'Sqlness Test (Basic)'. # Test: Search for the old job name in the entire repository. Expect: No occurrences. rg 'Sqlness Test \(Basic\)'Length of output: 29
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
How can such an important feature be implemented so poorly 😞
Checklist
Summary by CodeRabbit
sqlnessjob.sqlnessjob for better clarity.sqlness-kafka-waljob definition.